Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pallet-xcm patch with claim_assets extrinsic #7

Merged
merged 8 commits into from
Mar 4, 2024

Conversation

franciscoaguirre
Copy link

@franciscoaguirre franciscoaguirre commented Mar 4, 2024

Added changes for the polkadot-sdk 1.7.0 backport containing the claim_assets extrinsic.
Also, added tests for it for all major runtimes.

TODO

  • Add tests for the extrinsic
    • To system parachains
    • To the relays

@@ -122,3 +122,101 @@ macro_rules! test_parachain_is_trusted_teleporter {
}
};
}

#[macro_export]
macro_rules! test_chain_can_claim_assets {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franciscoaguirre can you please create issue and/or PR to move this macro to the https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/parachains/integration-tests/emulated/common/src/macros.rs , because we want to remove this helpers module from fellows :) check this: https://github.com/bkontur/runtimes/pull/7/files#diff-7346706278168c97dfec9e73bec1a115274a2be89a3147b914dd2eedec9f6269R31-R34
and also setup this tests for testnet runtimes in polkadot-sdk?
(We dont need to patch/backport this, so just fix it in master)

@bkontur bkontur merged commit 21fd3d1 into bkontur:bko-bump-to-1.7 Mar 4, 2024
28 of 31 checks passed
bkontur pushed a commit that referenced this pull request Mar 25, 2024
Fresh weights for Ethereum pallets
@foxweba3
Copy link

foxweba3 commented Jul 2, 2024

[![Modify Changelog](https://github.com/bkontur/runtimes/actions/workflows/changelog.yml/badge.svg)](https://github.com/bkontur/runtimes/actions/workflows/changelog.yml)

Copy link

@foxweba3 foxweba3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants