This repository was archived by the owner on Apr 29, 2025. It is now read-only.
Remove output_root override to prevent path duplication#7
Open
michaeljabbour wants to merge 2 commits intobkrabach:mainfrom
Open
Remove output_root override to prevent path duplication#7michaeljabbour wants to merge 2 commits intobkrabach:mainfrom
michaeljabbour wants to merge 2 commits intobkrabach:mainfrom
Conversation
- Remove output_root override from build_component.json to prevent path duplication - This ensures the output directory is used consistently across recipe execution
bkrabach
reviewed
Apr 1, 2025
| "recipe_path": "recipes/codebase_generator/generate_code.json", | ||
| "context_overrides": { | ||
| "model": "openai:o3-mini", | ||
| "output_root": "output", |
Owner
There was a problem hiding this comment.
removing this breaks existing desired behavior, if we want to add support for overriding, please change it to accept the context value and default to the current value of output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Benefits
Addressing Code Generation Concerns
This PR modifies a recipe file (build_component.json), not the generated code itself. Recipe files control how code is generated but are not themselves subject to code generation. This change helps prevent path duplication without modifying any generated code files, making it compatible with the project's code generation workflow.