Fixed handling of fixed compilation database on MSVC (#341)

bkryza · Nov 21, 2024 · 1645621 · 1645621
1 parent 4b3d613
commit 1645621
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/common/compilation_database.cc b/src/common/compilation_database.cc
@@ -30,14 +30,13 @@ compilation_database::auto_detect_from_directory(
     auto res = clang::tooling::CompilationDatabase::autoDetectFromDirectory(
         cfg.compilation_database_dir(), error_message);
 
-    if (!error_message.empty())
+    if (!error_message.empty() || res.get() == nullptr)
         throw error::compilation_database_error(error_message);
 
-    bool is_fixed{false};
-    if (dynamic_cast<clang::tooling::FixedCompilationDatabase *>(res.get()) !=
-        nullptr) {
-        is_fixed = true;
-    }
+    // This is a workaround to determine whether Clang loaded a fixed compilation
+    // database or proper. This cannot be done with dynamic_cast if RTTI was
+    // not enabled in the LLVM build
+    bool is_fixed{!res->getCompileCommands("no_such_file.no_such_extension").empty()};
 
     return std::make_unique<compilation_database>(
         std::move(res), cfg, is_fixed);