fix(source-aws): prevent s3 client from being logged when errors are thrown #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
blacha
pushed a commit
that referenced
this pull request
Nov 4, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>fs-aws: 11.3.0</summary> ## [11.3.0](fs-aws-v11.2.2...fs-aws-v11.3.0) (2024-11-03) ### Features * **fs-aws:** add callback when credentials are dynamically loaded ([29a1e3c](29a1e3c)) * **fs-aws:** add credential config for public and requester pays ([#1409](#1409)) ([0386b61](0386b61)) ### Dependencies * The following workspace dependencies were updated * dependencies * @chunkd/source-aws bumped from 11.0.3 to 11.0.4 </details> <details><summary>source-aws: 11.0.4</summary> ## [11.0.4](source-aws-v11.0.3...source-aws-v11.0.4) (2024-11-03) ### Bug Fixes * **source-aws:** prevent s3 client from being logged when errors are thrown ([#1475](#1475)) ([d146aa1](d146aa1)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
sourceobject is thrown when errors happen such as when a read fails. If this error is logged then thesoruce.clientis also logged and logging the entire S3 client is huge.Modification
Prevent the S3 object from being visible for loggers