right-click context-menu icons

[sean1138]

not sure if these are already on the radar, didn't see any open issues that looked relevant.

"loop" and "watch in picture-in-picture" don't have icons when right-clicking a video:

when right-clicking a text input "check spelling" text alignment doesn't match the other list items:


text alignment can be fixed in this comment

also noticed that the right edge of these context menu icons are colliding with a border/edge.

adding !important to this rule seems to fix the border collision at right of icons:
--context-menu-background-padding: var(--context-menu-background-padding-default) !important;

also missing a redo icon in the context menu - could just mirror or flip the undo icon horizontal.

will update if i find more.

[black7375]

It's a windows 7?
I need to reconfigure the VM environment, so I will recreate it on the weekend.

[sean1138]

yes, windows 7.

disabling this rule seemed to fix my text alignment in the right-click context menus.

userChrome.css rule disabled:

:not(menu, #ContentSelectDropdown, #context-navigation) > menupopup > menuitem:not(.menuitem-iconic, [type="checkbox"], .in-menulist),
    :not(menu, #ContentSelectDropdown, #context-navigation) > menupopup > menu:not(.menu-iconic, [type="checkbox"], .in-menulist),
    #blockedPopupDontShowMessage {
      padding-inline-start: calc(var(--context-menu-background-padding) + var(--context-menu-text-padding)) !important;
    }

disabling that rule makes a rule a few lines before it take effect (line 1121 in my file) giving me what looks to be the correct text alignment.

[sean1138]

disabling the padding-inline-start here fixes the alignment of my ublock origin addon icon in the context menu.

:not(menu, #ContentSelectDropdown, #context-navigation) > menupopup > menuitem,
  :not(menu, #ContentSelectDropdown, #context-navigation) > menupopup > menu,
  #blockedPopupDontShowMessage {
    background-position: left var(--context-menu-background-padding) center !important;
    padding-inline-start: var(--context-menu-background-padding) !important;
  }

[sean1138]

this issue was supposed to be just for the missing icons, sorry about that.
probable fix for text alignment and padding for win7:

/* Padding - Windows 7 */
  @media (-moz-os-version: windows-win7 ){
    :root {
      /*--context-menu-background-padding: 1em;*/
      --context-menu-text-padding: calc(var(--menu-padding) + var(--context-menu-background-padding-default) + 16px);
    }

    :not(menu, #ContentSelectDropdown, #context-navigation) > menupopup > menuitem,
    :not(menu, #ContentSelectDropdown, #context-navigation) > menupopup > menu,
    #blockedPopupDontShowMessage {
      background-position: left var(--context-menu-background-padding) center !important;
      padding-inline-start: 0 !important;
    }

    :not(menu, #ContentSelectDropdown, #context-navigation) > menupopup > menuitem:not(.menuitem-iconic, [type="checkbox"], .in-menulist),
    :not(menu, #ContentSelectDropdown, #context-navigation) > menupopup > menu:not(.menu-iconic, [type="checkbox"], .in-menulist),
    #blockedPopupDontShowMessage {
      /*padding-inline-start: calc(var(--context-menu-background-padding) + var(--context-menu-text-padding)) !important;*/
    }

    /* Checkbox */
    :not(menu, #ContentSelectDropdown, #context-navigation) > menupopup > menuitem[type="checkbox"][checked="false"] > .menu-iconic-left {
      padding-inline-start: var(--context-menu-text-padding);
    }
  }

  /* Padding - Windows 8+ */
  @media (-moz-os-version: windows-win8 ),
         (-moz-os-version: windows-win10) {
    :root {
/* code unchanged from here on */

screenshot of the code for more context?

looks correct here with the above added to my userChrome.css file :)

[black7375]

Thank you.
I think the code will help. We will add it to the CREDITS list after this patch.

[black7375]

Thank you 😍