Highlight Test and Sandbox environments differently
#158
Conversation
src/omnibar/omnibar.ts
Outdated
| @@ -578,7 +623,7 @@ function messageHandler(event: MessageEvent): void { | |||
| BBOmnibarUserActivity.userRenewedSession(); | |||
| break; | |||
| case 'environment-update': | |||
| handleEnvironmentUpdate(message.name); | |||
| handleEnvironmentUpdate(message.name, message.additionalInfo, message.url); | |||
There was a problem hiding this comment.
I would prefer description over additionalInfo for the property name.
There was a problem hiding this comment.
I prefer description as well. Thanks!
src/omnibar/omnibar.ts
Outdated
| text-overflow: ellipsis; | ||
| white-space: nowrap; | ||
| } | ||
|
|
||
| .sky-omnibar-environment-info { |
There was a problem hiding this comment.
I would look into using flexbox or another technique rather than float: right, since floating elements has an effect on subsequent elements and usually needs a clear: both after it.
There was a problem hiding this comment.
Per our side conversation, I changed these new elements to spans.
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 1120 1138 +18
Branches 189 191 +2
=========================================
+ Hits 1120 1138 +18
Continue to review full report at Codecov.
|
When a user is in an environment that is marked as either
TestorSandbox, highlight the environment bar in a style default then just the gray color.Addresses #143