Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Added ability to specify theme information and to update the omnibar after render #67

Merged
merged 8 commits into from
Jun 14, 2018

Conversation

Blackbaud-PaulCrowder
Copy link
Member

This supports the eventual release of the theming capabilities of omnibar.

@codecov-io
Copy link

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #67   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         746    758   +12     
  Branches      124    128    +4     
=====================================
+ Hits          746    758   +12
Impacted Files Coverage Δ
src/omnibar/omnibar.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b35d755...13d0f22. Read the comment docs.

Copy link
Contributor

@Blackbaud-TerryHelems Blackbaud-TerryHelems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make BBOmnibarNavigationItemDisplayStyle a bitmask enum instead:

{
  Icon=1,
  Text=2,
  IconAndText=3
}

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder merged commit ad40632 into master Jun 14, 2018
@Blackbaud-PaulCrowder Blackbaud-PaulCrowder deleted the theming branch June 14, 2018 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants