Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Stopping same param from getting added more than once #182

Merged
merged 4 commits into from
Jun 15, 2017

Conversation

Blackbaud-BobbyEarl
Copy link

@Blackbaud-BobbyEarl Blackbaud-BobbyEarl commented Jun 13, 2017

@codecov-io
Copy link

codecov-io commented Jun 13, 2017

Codecov Report

Merging #182 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #182   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          39     39           
  Lines         942    946    +4     
  Branches      131    132    +1     
=====================================
+ Hits          942    946    +4
Flag Coverage Δ
#builder 100% <ø> (ø) ⬆️
#runtime 100% <100%> (ø) ⬆️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
runtime/params.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1f0d7f...7c4041b. Read the comment docs.

@Blackbaud-BobbyEarl
Copy link
Author

Ahh thanks @blackbaud-brandonstirnaman. I'm a little premature on creating the PR. I do believe this "solves" blackbaud/skyux2#742, but I'm digging in to the actual root cause at the moment.

@Blackbaud-BobbyEarl
Copy link
Author

Did some more debugging today with the help of @Blackbaud-PaulCrowder. This bug presents itself when all of the following are true:

  • Consumer is using the SkyAuthHttp.request method as opposed to one of the convenience methods, get, post, etc.
  • Consumer is subscribing to the same request multiple times.
  • Consumer is not using Observable.share() method to make it a hot observable, which means a new request is created for each subscriber.

We decided implementing the logic to not add the same variable to a url via the getUrl method is the most consistent fix, but it was important to understand how this bug was happening, which I wasn't entirely sure on when the PR was first submitted.

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder merged commit d9fa511 into master Jun 15, 2017
@Blackbaud-PaulCrowder Blackbaud-PaulCrowder deleted the multiple-params branch June 15, 2017 14:26
Blackbaud-DiHuynh pushed a commit to Blackbaud-DiHuynh/skyux-builder that referenced this pull request Jul 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants