Build component libraries #198

Blackbaud-SteveBrush · 2017-06-21T18:44:38Z

Surfaced new command, skyux build-public-library.
Bundles all files located in src/app/public as UMD module.
After the bundle is successfully created, the pipeline is responsible for publishing to NPM.

To test locally:

Clone the feature-cleanup branch from skyux-template-library: https://github.com/blackbaud/skyux-template-library/tree/feature-cleanup
Type npm install && skyux build-public-library

* Updated dependencies * Updated skyux2 version * Updated dependencies * Using template branch for testing * Reverted protractor config * Pointing to dev branch for local testing * Updated package json * Using explicit types * Updated version of skyux * Updated dependencies * Fixed linting errors * Added fontfaceobserver to types * Fixed tslint errors * Fixed tslint errors * Ensure that the files are not directories * Update tests for file processor * Update plugin-file-processor.js * Update plugin-file-processor.spec.js * Updated version of skyux * Updated config * Added specific version of firefox * Updated tsconfig * Updating travis version * Updated version of firefox * Updated directconnect * Updated protractor * Added firfox launcher * Removed directConnect * Reverting back to directConnect * Removed firefox * Re-added firefox * Accepting insecure certs * Enabled directconnect * use chrome with chromOptions in protractor-dev.conf.js * add sources to travis.yml * add dist: trusty * Removed tsconfig paths * Update typescript-loader * Simpler method for avoiding directories * As ts-node option and fix e2e test

* Using omnibarConfigMap for envid/svcid * Fixing implicit any

* Fixed codelyzer path * Added node_modules to excludes * Readded node_modules

* Added ignore pattern to component generator * Component generator should ignore public folder * Updated ignore pattern

* Do not check directories * Added nodir option

* Updated branch to master * Fixed bug with ignore components pattern * Updated unit tests

* Update CHANGELOG.md * Update package.json

codecov-io · 2017-06-22T16:45:16Z

Codecov Report

Merging #198 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #198    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files          42     47     +5     
  Lines         996   1110   +114     
  Branches      153    157     +4     
======================================
+ Hits          996   1110   +114

Flag	Coverage Δ
#builder	`100% <100%> (ø)`	⬆️
#runtime	`100% <ø> (ø)`	⬆️
#srcapp	`100% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
cli/utils/prepare-library-package.js	`100% <100%> (ø)`
cli/utils/stage-library-ts.js	`100% <100%> (ø)`
...fig/webpack/build-public-library.webpack.config.js	`100% <100%> (ø)`
cli/build.js	`100% <100%> (ø)`	⬆️
cli/utils/run-compiler.js	`100% <100%> (ø)`
index.js	`100% <100%> (ø)`	⬆️
cli/build-public-library.js	`100% <100%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24811b2...40ccfc5. Read the comment docs.

* Fixed type error * Updated skyux * Updated skyux

* Fixed type error * Updated skyux * Updated skyux * Update package.json * Update CHANGELOG.md

* Fixed typo in OmnibarConfigMap. Allowing querystring params to be case insensitive * Test cleanup * Removed unnecessary mapping functionality

Blackbaud-SteveBrush · 2017-06-27T16:34:36Z

@Blackbaud-BobbyEarl I still need to finish up the unit tests for this branch, but do you mind running through it quickly to make sure there aren't any glaring issues with my approach?

Blackbaud-BobbyEarl · 2017-06-27T20:58:34Z

Really the only thing that stands out, is the Travis shell scripts. Those make sense for our open source libraries, but not sure they'll be the same technique we use to publish to the VSTS registry through our pipeline. We may need to regroup on that aspect of things.

* Removed tslint-loader * Created custom sky-tslint loader

* Updated changelog, version * Update CHANGELOG.md * Update CHANGELOG.md

* Updated package dependencies * Update skyux version * use appropriate template branch

* Updates for rc.5

Blackbaud-SteveBrush · 2017-07-03T22:28:12Z

@Blackbaud-BobbyEarl This is ready for an official review.

Blackbaud-BobbyEarl · 2017-07-10T18:18:18Z

cli/build-public-library.js

+  const config = webpackConfig.getWebpackConfig(skyPagesConfig);
+  const compiler = webpack(config);
+
+  return new Promise((resolve, reject) => {


I wonder if https://github.com/blackbaud/skyux-builder/blob/master/cli/build.js#L133-L163 is similar enough to factor this functionality out?

Blackbaud-BobbyEarl · 2017-07-10T18:48:54Z

index.js

@@ -13,6 +13,9 @@ module.exports = {
      case 'build':
        require('./cli/build')(argv, skyPagesConfig, webpack);
        break;
+      case 'build-public-library':
+        require('./cli/build-public-library')(skyPagesConfig);


I probably originally did it for testing, but should we pass in webpack here to stay consistent?

Blackbaud-BobbyEarl

This looks good to me Steve!

Tagging @blackbaud-johnly for the new skyux build-public-library command.

Blackbaud-PatrickOFriel and others added 15 commits June 16, 2017 21:20

updates for rc.0 release (#190)

a7c3277

Omnibar config (#193)

189eb63

* Using omnibarConfigMap for envid/svcid * Fixing implicit any

Fixed codelyzer path (#192)

314aefd

* Fixed codelyzer path * Added node_modules to excludes * Readded node_modules

Ignore public directory when generating components (#187)

28830ba

* Added ignore pattern to component generator * Component generator should ignore public folder * Updated ignore pattern

Plugin File Processor should not check directories (#186)

424672f

* Do not check directories * Added nodir option

Updated CHANGELOG.md and package.json for 1.0.0-rc.1 (#194)

1085d54

Added basic files

7bb867e

Updated template branch, bug fix for component pattern (#195)

6de9f1f

* Updated branch to master * Fixed bug with ignore components pattern * Updated unit tests

Added travis scripts

3468ac0

Merge branch 'rc-ng4-upgrade' into lib-release

650fc82

Release 1.0.0 rc.2 (#196)

9e52340

* Update CHANGELOG.md * Update package.json

Remove extra s. (#197)

b9f8688

Merge branch 'rc-ng4-upgrade' into lib-release

6c665c6

Added basic spec files

4bf171d

Blackbaud-SteveBrush and others added 6 commits June 22, 2017 15:13

Added unit tests for cli

37cf6e7

Fixed type error, updated SKY UX (#199)

256d4b8

* Fixed type error * Updated skyux * Updated skyux

Release 1.0.0 rc.3 (#200)

db62d70

* Fixed type error * Updated skyux * Updated skyux * Update package.json * Update CHANGELOG.md

Merge branch 'rc-ng4-upgrade' into lib-release

64984f1

Param functionality (#201)

978813f

* Fixed typo in OmnibarConfigMap. Allowing querystring params to be case insensitive * Test cleanup * Removed unnecessary mapping functionality

Merge branch 'rc-ng4-upgrade' into lib-release

a7f6ac3

Blackbaud-SteveBrush requested a review from Blackbaud-BobbyEarl June 27, 2017 17:10

Blackbaud-SteveBrush and others added 5 commits June 28, 2017 14:56

Removed tslint loader

bc96df6

Readded webpack test

f375f52

Fixed skyux test/watch performance (#202)

4272474

* Removed tslint-loader * Created custom sky-tslint loader

Release 1.0.0-rc.4 (#207)

3ed462a

* Updated changelog, version * Update CHANGELOG.md * Update CHANGELOG.md

Added to skyux builder (#204)

7fcfe14

Blackbaud-SteveBrush and others added 7 commits July 1, 2017 11:17

Updated package dependencies (#208)

5454e9a

* Updated package dependencies * Update skyux version * use appropriate template branch

Add hash routing option for easy mode. (#206)

9320118

Updates rc5 (#209)

3846c64

* Updates for rc.5

Capitalize Angular. (#211)

7c58a14

Merge branch 'rc-ng4-upgrade' into lib-release

bde093f

Renamed cli command

aecf452

100% code coverage

fd2cab3

Blackbaud-SteveBrush changed the title ~~[HOLD] Allow component libraries to release to NPM~~ Build component libraries Jul 3, 2017

Blackbaud-SteveBrush mentioned this pull request Jul 3, 2017

Added scripts blackbaud/skyux-travis#1

Merged

Blackbaud-SteveBrush changed the base branch from rc-ng4-upgrade to master July 5, 2017 15:54

Blackbaud-SteveBrush added 3 commits July 5, 2017 11:54

Merge branch 'master' into lib-release

839f2e0

Merge branch 'master' into lib-release

c77c51f

Enforcing package main name

40481c8

Blackbaud-BobbyEarl reviewed Jul 10, 2017

View reviewed changes

Blackbaud-SteveBrush added 4 commits July 11, 2017 10:29

Factored out compiler step

4082cb3

Fixed unit test

4245e52

Fixed unit tests

8ef39fa

Fixed e2e tests

94c7f7c

Blackbaud-BobbyEarl approved these changes Jul 12, 2017

View reviewed changes

Merge branch 'master' into lib-release

40ccfc5

Blackbaud-SteveBrush merged commit 276d9a6 into master Jul 12, 2017

Blackbaud-SteveBrush deleted the lib-release branch July 12, 2017 16:47

Blackbaud-SteveBrush mentioned this pull request Jul 26, 2017

Document skyux build-public-library command blackbaud/skyux2#945

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build component libraries #198

Build component libraries #198

Blackbaud-SteveBrush commented Jun 21, 2017 •

edited

Loading

codecov-io commented Jun 22, 2017 •

edited

Loading

Blackbaud-SteveBrush commented Jun 27, 2017

Blackbaud-BobbyEarl commented Jun 27, 2017

Blackbaud-SteveBrush commented Jul 3, 2017

Blackbaud-BobbyEarl Jul 10, 2017

Blackbaud-BobbyEarl Jul 10, 2017

Blackbaud-BobbyEarl left a comment

Build component libraries #198

Build component libraries #198

Conversation

Blackbaud-SteveBrush commented Jun 21, 2017 • edited Loading

codecov-io commented Jun 22, 2017 • edited Loading

Codecov Report

Blackbaud-SteveBrush commented Jun 27, 2017

Blackbaud-BobbyEarl commented Jun 27, 2017

Blackbaud-SteveBrush commented Jul 3, 2017

Blackbaud-BobbyEarl Jul 10, 2017

Choose a reason for hiding this comment

Blackbaud-BobbyEarl Jul 10, 2017

Choose a reason for hiding this comment

Blackbaud-BobbyEarl left a comment

Choose a reason for hiding this comment

Blackbaud-SteveBrush commented Jun 21, 2017 •

edited

Loading

codecov-io commented Jun 22, 2017 •

edited

Loading