Added `skyux lint` command #205

Blackbaud-SteveBrush · 2017-06-29T01:52:31Z

Reason for the change:

Type checking (apparently) is only available for TSLint CLI. The "runner" is only executed within the CLI (https://github.com/palantir/tslint/blob/1ec0bace70fa834b33c8851a5768596dc2155373/src/tslint-cli.ts#L24 and https://github.com/palantir/tslint/blob/1ec0bace70fa834b33c8851a5768596dc2155373/src/runner.ts#L160).
Also, type checking only works when you have a TSLint "project", i.e., a tsconfig.json file, so we can't run a blanket type check on all source files (unless defined in tsconfig.json). https://palantir.github.io/tslint/usage/type-checking/

What this branch accomplishes:

I removed our custom TSLint linter from Webpack entirely, and created a separate spawn to run the type checking through the CLI.
New command: skyux lint.
This command is executed during build, e2e, test, and watch. It is ignored for serve.
I had to make a few syntactic changes to some of the builder's source code because of the new linting process.

* Updated dependencies * Updated skyux2 version * Updated dependencies * Using template branch for testing * Reverted protractor config * Pointing to dev branch for local testing * Updated package json * Using explicit types * Updated version of skyux * Updated dependencies * Fixed linting errors * Added fontfaceobserver to types * Fixed tslint errors * Fixed tslint errors * Ensure that the files are not directories * Update tests for file processor * Update plugin-file-processor.js * Update plugin-file-processor.spec.js * Updated version of skyux * Updated config * Added specific version of firefox * Updated tsconfig * Updating travis version * Updated version of firefox * Updated directconnect * Updated protractor * Added firfox launcher * Removed directConnect * Reverting back to directConnect * Removed firefox * Re-added firefox * Accepting insecure certs * Enabled directconnect * use chrome with chromOptions in protractor-dev.conf.js * add sources to travis.yml * add dist: trusty * Removed tsconfig paths * Update typescript-loader * Simpler method for avoiding directories * As ts-node option and fix e2e test

* Using omnibarConfigMap for envid/svcid * Fixing implicit any

* Fixed codelyzer path * Added node_modules to excludes * Readded node_modules

* Added ignore pattern to component generator * Component generator should ignore public folder * Updated ignore pattern

* Do not check directories * Added nodir option

* Updated branch to master * Fixed bug with ignore components pattern * Updated unit tests

* Update CHANGELOG.md * Update package.json

* Fixed type error * Updated skyux * Updated skyux

* Fixed type error * Updated skyux * Updated skyux * Update package.json * Update CHANGELOG.md

* Fixed typo in OmnibarConfigMap. Allowing querystring params to be case insensitive * Test cleanup * Removed unnecessary mapping functionality

* Removed tslint-loader * Created custom sky-tslint loader

* Updated changelog, version * Update CHANGELOG.md * Update CHANGELOG.md

* Updated package dependencies * Update skyux version * use appropriate template branch

* Updates for rc.5

…ux-builder into feature-skyux-lint

codecov-io · 2017-07-21T00:47:42Z

Codecov Report

Merging #205 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #205   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          54     53    -1     
  Lines        1223   1238   +15     
  Branches      178    183    +5     
=====================================
+ Hits         1223   1238   +15

Flag	Coverage Δ
#builder	`100% <100%> (ø)`	⬆️
#runtime	`100% <ø> (ø)`	⬆️
#srcapp	`100% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
config/webpack/test.webpack.config.js	`100% <ø> (ø)`	⬆️
runtime/i18n/resources.service.ts	`100% <ø> (ø)`	⬆️
cli/utils/ts-linter.js	`100% <100%> (ø)`
cli/build.js	`100% <100%> (ø)`	⬆️
index.js	`100% <100%> (ø)`	⬆️
cli/test.js	`100% <100%> (ø)`	⬆️
cli/lint.js	`100% <100%> (ø)`
cli/build-public-library.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a49f46...67e570c. Read the comment docs.

Blackbaud-SteveBrush · 2017-07-25T21:21:16Z

tsconfig.json

+    "baseUrl": ".",
+    "paths": {
+      "@blackbaud/skyux-builder/*": [
+        "./node_modules/@blackbaud/skyux-builder/*",


Added this to tell TS about the webpack aliases.
https://www.typescriptlang.org/docs/handbook/module-resolution.html#path-mapping

Blackbaud-SteveBrush · 2017-07-25T21:22:10Z

tsconfig.json

  },
+  "exclude": [
+    "node_modules",
+    "**/*.aot.ts"


Ignore TS's Cannot find module './ngfactory/app/app.module.ngfactory'. within the main-internal.aot.ts file.

Blackbaud-SteveBrush · 2017-07-26T13:18:54Z

@Blackbaud-PaulCrowder This one is ready for another look.

Blackbaud-PatrickOFriel and others added 14 commits June 16, 2017 21:20

updates for rc.0 release (#190)

a7c3277

Omnibar config (#193)

189eb63

* Using omnibarConfigMap for envid/svcid * Fixing implicit any

Fixed codelyzer path (#192)

314aefd

* Fixed codelyzer path * Added node_modules to excludes * Readded node_modules

Ignore public directory when generating components (#187)

28830ba

* Added ignore pattern to component generator * Component generator should ignore public folder * Updated ignore pattern

Plugin File Processor should not check directories (#186)

424672f

* Do not check directories * Added nodir option

Updated CHANGELOG.md and package.json for 1.0.0-rc.1 (#194)

1085d54

Updated template branch, bug fix for component pattern (#195)

6de9f1f

* Updated branch to master * Fixed bug with ignore components pattern * Updated unit tests

Release 1.0.0 rc.2 (#196)

9e52340

* Update CHANGELOG.md * Update package.json

Remove extra s. (#197)

b9f8688

Fixed type error, updated SKY UX (#199)

256d4b8

* Fixed type error * Updated skyux * Updated skyux

Release 1.0.0 rc.3 (#200)

db62d70

* Fixed type error * Updated skyux * Updated skyux * Update package.json * Update CHANGELOG.md

Param functionality (#201)

978813f

* Fixed typo in OmnibarConfigMap. Allowing querystring params to be case insensitive * Test cleanup * Removed unnecessary mapping functionality

Added lint command

ee0b61f

Blackbaud-SteveBrush mentioned this pull request Jun 29, 2017

Fixed skyux test/watch performance #202

Merged

Blackbaud-SteveBrush and others added 8 commits June 29, 2017 14:16

Fixed skyux test/watch performance (#202)

4272474

* Removed tslint-loader * Created custom sky-tslint loader

Release 1.0.0-rc.4 (#207)

3ed462a

* Updated changelog, version * Update CHANGELOG.md * Update CHANGELOG.md

Added to skyux builder (#204)

7fcfe14

Updated package dependencies (#208)

5454e9a

* Updated package dependencies * Update skyux version * use appropriate template branch

Add hash routing option for easy mode. (#206)

9320118

Updates rc5 (#209)

3846c64

* Updates for rc.5

Capitalize Angular. (#211)

7c58a14

Wrote failing test. Then made config property public for template (#212)

f7c24e9

Blackbaud-SteveBrush closed this Jul 7, 2017

Blackbaud-SteveBrush reopened this Jul 20, 2017

Merge branch 'rc-ng4-upgrade' into feature-skyux-lint

d3b2b5e

Blackbaud-SteveBrush changed the base branch from rc-ng4-upgrade to master July 20, 2017 14:02

Blackbaud-SteveBrush added 3 commits July 20, 2017 10:06

Merge branch 'master' into feature-skyux-lint

29ec11d

Added skyux lint files

6be7ba4

Update CHANGELOG.md

69def38

Blackbaud-SteveBrush added 5 commits July 20, 2017 14:41

Updated unit tests

7ebf50a

Merge branch 'feature-skyux-lint' of https://github.com/blackbaud/sky…

b31d875

…ux-builder into feature-skyux-lint

Updated unit tests

b3d97be

Fixed e2e test

d918a48

Fixed e2e tests

931d9ff

Blackbaud-SteveBrush changed the title ~~[HOLD] Added skyux lint command~~ Added skyux lint command Jul 21, 2017

Blackbaud-SteveBrush requested a review from Blackbaud-PaulCrowder July 21, 2017 01:55

Update build.js

b186d13

Blackbaud-SteveBrush assigned Blackbaud-PaulCrowder Jul 21, 2017

Blackbaud-SteveBrush added 8 commits July 24, 2017 16:16

Merge branch 'master' into feature-skyux-lint

da8467d

Merge branch 'master' into feature-skyux-lint

6294917

Added colors to logger

da33ec8

Updated linter result

d7eb664

Merged conflicts

0aa68d8

Added error log after karma reporter

3525656

Update test.js

2d4b2f8

Merge branch 'master' into feature-skyux-lint

68d8193

Blackbaud-SteveBrush commented Jul 25, 2017

View reviewed changes

Added errors to linter result

67e570c

Blackbaud-PaulCrowder approved these changes Jul 26, 2017

View reviewed changes

Blackbaud-PaulCrowder merged commit 1cbbf40 into master Jul 26, 2017

Blackbaud-PaulCrowder deleted the feature-skyux-lint branch July 26, 2017 16:11

This was referenced Jul 26, 2017

Document skyux lint command blackbaud/skyux2#944

Closed

Add TSLint as a separate step to ensure all files are checked blackbaud/skyux2#411

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added `skyux lint` command #205

Added `skyux lint` command #205

Blackbaud-SteveBrush commented Jun 29, 2017 •

edited

Loading

codecov-io commented Jul 21, 2017 •

edited

Loading

Blackbaud-SteveBrush Jul 25, 2017

Blackbaud-SteveBrush Jul 25, 2017

Blackbaud-SteveBrush commented Jul 26, 2017

Added skyux lint command #205

Added skyux lint command #205

Conversation

Blackbaud-SteveBrush commented Jun 29, 2017 • edited Loading

codecov-io commented Jul 21, 2017 • edited Loading

Codecov Report

Blackbaud-SteveBrush Jul 25, 2017

Choose a reason for hiding this comment

Blackbaud-SteveBrush Jul 25, 2017

Choose a reason for hiding this comment

Blackbaud-SteveBrush commented Jul 26, 2017

Added `skyux lint` command #205

Added `skyux lint` command #205

Blackbaud-SteveBrush commented Jun 29, 2017 •

edited

Loading

codecov-io commented Jul 21, 2017 •

edited

Loading