Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Added better caching strategy and fallback to non-region-specific languages #226

Merged
merged 5 commits into from
Jul 14, 2017

Conversation

Blackbaud-PaulCrowder
Copy link
Member

No description provided.

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder changed the title Added better caching strategy and fallback to non-region-specific languages [HOLD] Added better caching strategy and fallback to non-region-specific languages Jul 14, 2017
@Blackbaud-PaulCrowder
Copy link
Member Author

Just realized I'm going to need another unit test.

@codecov-io
Copy link

codecov-io commented Jul 14, 2017

Codecov Report

Merging #226 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #226   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          53     53           
  Lines        1204   1208    +4     
  Branches      172    174    +2     
=====================================
+ Hits         1204   1208    +4
Flag Coverage Δ
#builder 100% <ø> (ø) ⬆️
#runtime 100% <100%> (ø) ⬆️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
runtime/i18n/resources.service.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd93e97...5555eed. Read the comment docs.

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder changed the title [HOLD] Added better caching strategy and fallback to non-region-specific languages Added better caching strategy and fallback to non-region-specific languages Jul 14, 2017
@Blackbaud-PaulCrowder
Copy link
Member Author

Ready for review

@Blackbaud-BobbyEarl Blackbaud-BobbyEarl merged commit f223bc4 into master Jul 14, 2017
@Blackbaud-BobbyEarl Blackbaud-BobbyEarl deleted the resource-service-fixes branch July 14, 2017 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants