This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Added a check for a route fragment in the navigationEnd event #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 54 54
Lines 1221 1223 +2
Branches 177 178 +1
=====================================
+ Hits 1221 1223 +2
Continue to review full report at Codecov.
|
src/app/app.component.spec.ts
Outdated
| @@ -54,7 +54,12 @@ describe('AppComponent', () => { | |||
| events: { | |||
| subscribe: handler => subscribeHandler = handler | |||
| }, | |||
| navigateByUrl: url => navigateByUrlParams = url | |||
| navigateByUrl: url => navigateByUrlParams = url, | |||
| parseUrl: url => { | |||
There was a problem hiding this comment.
Check your spaces count after the lambda, and after the undefined, below.
…ure-anchor-link-scrolling
…ackbaud-BrandonJones/skyux-builder into feature-anchor-link-scrolling
|
@Blackbaud-PaulCrowder I don't see anything wrong with this one. You? |
|
Seems fine to me. |
Blackbaud-SteveBrush
approved these changes
Jul 25, 2017
Blackbaud-DiHuynh
pushed a commit
to Blackbaud-DiHuynh/skyux-builder
that referenced
this pull request
Jul 10, 2020
Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.2. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The navigationEnd subscription was causing pages to scroll to the top of the page on every navigation event. This was breaking in-page navigation to fragments on the page. With this change, it allows apps to scroll to elements on their page based on the fragment, as is expected from in page anchor links.