Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Mark change detector for check after a resource string is loaded asynchronously #243

Merged
merged 2 commits into from
Jul 25, 2017

Conversation

Blackbaud-PaulCrowder
Copy link
Member

@codecov-io
Copy link

codecov-io commented Jul 25, 2017

Codecov Report

Merging #243 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #243   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          53     53           
  Lines        1215   1218    +3     
  Branches      175    177    +2     
=====================================
+ Hits         1215   1218    +3
Flag Coverage Δ
#builder 100% <ø> (ø) ⬆️
#runtime 100% <100%> (ø) ⬆️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
runtime/i18n/resources.pipe.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 837b0dd...7e3fd3b. Read the comment docs.

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested all CLI commands using the latest template (as well as an async request to retrieve the localizations).

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder merged commit 89afc4f into master Jul 25, 2017
@Blackbaud-PaulCrowder Blackbaud-PaulCrowder deleted the resource-pipe-mark-for-check branch July 25, 2017 15:27
Blackbaud-DiHuynh pushed a commit to Blackbaud-DiHuynh/skyux-builder that referenced this pull request Jul 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants