-
Notifications
You must be signed in to change notification settings - Fork 28
Added ability to specify a permission scope to SkyAuthHttp #245
Conversation
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 54 54
Lines 1241 1249 +8
Branches 183 184 +1
=====================================
+ Hits 1241 1249 +8
Continue to review full report at Codecov.
|
I'm assuming if multiple scopes were needed, we could pass in a comma-separated string, |
When SKY UX worked with the permissions and auth teams on defining permission scopes, we decided we would not support accepting multiple permission scopes when retrieving a token. If a caller needs more permissions than an existing permission scope already contains, they will need to register a new permission scope with the permissions service. |
// property set. When chained, the end call would look something like this: | ||
// http.withScope('abc').get(url); | ||
|
||
const http = new SkyAuthHttp( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this; prevents the scope from being applied to all subsequent requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
No description provided.