This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Allowing --no-build flag during skyux e2e #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 58 58
Lines 1340 1349 +9
Branches 197 200 +3
=====================================
+ Hits 1340 1349 +9
Continue to review full report at Codecov.
|
cli/e2e.js
Outdated
| logger.info('Running build...'); | ||
| build(argv, skyPagesConfig, webpack) | ||
| .then(stats => { | ||
| logger.info('Build complete.'); | ||
| console.log(stats.toJson().chunks); |
There was a problem hiding this comment.
Did you mean to leave the console log in here?
cli/e2e.js
Outdated
| if (argv.build === false) { | ||
| logger.info('Skipping build step'); | ||
| return resolve({ | ||
| metadata: fs.readJsonSync('dist/metadata.json') |
There was a problem hiding this comment.
I know fs likes to throw errors around. Are we fairly confident that metadata.json will always exist? ie, we don't need to wrap this in a try/catch?
|
Great feedback @Blackbaud-SteveBrush. Should be addressed in latest. I haven't seen rampant |
Blackbaud-SteveBrush
approved these changes
Sep 5, 2017
Blackbaud-DiHuynh
pushed a commit
to Blackbaud-DiHuynh/skyux-builder
that referenced
this pull request
Jul 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.