This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
Feature help library #270
Merged
Blackbaud-BobbyEarl
merged 23 commits into
blackbaud:master
from
Blackbaud-BrandonJones:feature-help-library
Sep 19, 2017
Merged
Feature help library #270
Changes from 20 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
4b8fd4f
upgrading to helpclient v 1.0.2
Blackbaud-BrandonJones 5d9ebdf
package update
Blackbaud-BrandonJones f23c760
added tests and updates to adding the BBHelpModule to skyPages based …
Blackbaud-BrandonJones a8bbec3
updated interface
Blackbaud-BrandonJones 154c57c
updated test to use variable for clarity
Blackbaud-BrandonJones bdafc06
re-wording test for clarity
Blackbaud-BrandonJones 71346ae
rewording for line length
Blackbaud-BrandonJones 951cd3b
added test for no BBHelpModule import.
Blackbaud-BrandonJones c79b48d
Merge branch 'master' of github.com:blackbaud/skyux-builder into feat…
Blackbaud-BrandonJones ad10771
added skyux lib help
Blackbaud-BrandonJones c681c53
merge from master
Blackbaud-BrandonJones 933603f
updated test and generator code
Blackbaud-BrandonJones b961740
test updates
Blackbaud-BrandonJones ebcc059
merge with master
Blackbaud-BrandonJones e631fcc
moved node module imports to separate array
Blackbaud-BrandonJones 421ee11
Merge branch 'master' into feature-help-library
Blackbaud-PaulCrowder 64d547c
Merge branch 'master' of github.com:blackbaud/skyux-builder into feat…
Blackbaud-BrandonJones 17accda
updated tests and linter issues
Blackbaud-BrandonJones 5f62229
Merge branch 'feature-help-library' of https://github.com/Blackbaud-B…
Blackbaud-BrandonJones 3cab0bc
linting adjustment
Blackbaud-BrandonJones 1c05167
made the bbHelpModule optional, updated tests, removed interface for …
Blackbaud-BrandonJones 6812035
grammar fix
Blackbaud-BrandonJones a45d6df
nodeModuleImports
Blackbaud-BrandonJones File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ import { | |
BBOmnibarSearchArgs | ||
} from '@blackbaud/auth-client'; | ||
|
||
import { BBHelp } from '@blackbaud/help-client'; | ||
import { HelpInitializationService } from '@blackbaud/skyux-lib-help'; | ||
|
||
import { | ||
SkyAppConfig, | ||
|
@@ -74,6 +74,7 @@ export class AppComponent implements OnInit { | |
private windowRef: SkyAppWindowRef, | ||
private config: SkyAppConfig, | ||
private styleLoader: SkyAppStyleLoader, | ||
private helpInitService: HelpInitializationService, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we use a similar approach to the optional There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good thoughts! I'll see what I can do. |
||
@Optional() private searchProvider?: SkyAppSearchResultsProvider | ||
) { | ||
this.styleLoader.loadStyles() | ||
|
@@ -194,7 +195,12 @@ export class AppComponent implements OnInit { | |
} | ||
|
||
if (helpConfig) { | ||
BBHelp.load(helpConfig); | ||
|
||
if (this.config.runtime.params.has('svcid')) { | ||
helpConfig.extends = this.config.runtime.params.get('svcid'); | ||
} | ||
|
||
this.helpInitService.load(helpConfig); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious about the creation of this interface. We'd previous used interfaces for the auth and help clients. We decided against that; however, as somewhat painfully tied those libraries to builder, but without any benefit (consumers never use the interface).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. I added it because I was using it for the Help Library and thought builder may want to also make use of it. That being said, having to update it in multiple places should one change would be a pain, I am fine with removing it.