This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Two fixes for our spa's integration with the GoodData library. #298
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,6 +30,8 @@ require('zone.js/dist/sync-test'); | |
| require('zone.js/dist/proxy'); | ||
| require('zone.js/dist/jasmine-patch'); | ||
|
|
||
| require('reflect-metadata'); | ||
|
There was a problem hiding this comment. @Blackbaud-MikitaYankouski Mind providing more information on how this affects your unit tests? There was a problem hiding this comment. Without this line the unit tests do not run and the code coverage results aren't printed so our build ends up failing as well. |
||
|
|
||
| // RxJS | ||
| require('rxjs/Rx'); | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Blackbaud-MikitaYankouski, in your testing, did you run into any problems upgrading to this version of rxjs. Our dependency chain isn't crystal clear, and we've ran into problems when upgrading the dependency in builder, but not upgrading it in the skyux2 components.
https://github.com/blackbaud/skyux2/blob/master/package.json#L108
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just re-ran the all the tests and haven't ran into any issues!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The template also works with these changes. A point of note: UX does not directly depend on rxjs, so the mixmatched versions shouldn't affect a SPA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using a third party library that is required by our app that is more heavily dependent on rxjs, and they use this higher version and having two version in our node_modules gave us build errors.