This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Wrapped the first and last parts with path separators so that only distinct parts are matched #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stinct parts are matched Fixes blackbaud/skyux2#1222
Blackbaud-PaulCrowder
changed the title
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 59 59
Lines 1370 1370
Branches 208 208
=====================================
Hits 1370 1370
Continue to review full report at Codecov.
|
Blackbaud-PaulCrowder
changed the title
| '/src/app/fixtures/test.ts', | ||
| '/src/app/testing/test.ts', | ||
| '/src/app/lib/test.ts', | ||
| '/src/app/index.ts' |
There was a problem hiding this comment.
@Blackbaud-PaulCrowder Should we also test Window's backslashes?
const disallowedPaths = [
...
String.raw`\src\app\lib\test.ts`
];
There was a problem hiding this comment.
Yeah, I'll add some.
Blackbaud-SteveBrush
approved these changes
Oct 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes blackbaud/skyux2#1222