This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Default params #320
Merged
Default params #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also includes a minor change to remove the `private` accessor from the `SkyAppRuntimeConfigParams` constructor parameters since they were not used anywhere in the class other than the constructor.
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 60 60
Lines 1407 1423 +16
Branches 217 222 +5
=====================================
+ Hits 1407 1423 +16
Continue to review full report at Codecov.
|
Blackbaud-BobbyEarl
previously approved these changes
Nov 1, 2017
Blackbaud-BobbyEarl
dismissed
their stale review
Prematurely provided review.
|
Ha. I like the comment on the failing line. skyux-builder/cli/utils/browser.js Line 12 in 37878bb |
Blackbaud-BobbyEarl
approved these changes
Nov 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: blackbaud/skyux2#1251