Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Added ability to generate a component from the CLI #330

Merged
merged 3 commits into from
Nov 14, 2017

Conversation

Blackbaud-PaulCrowder
Copy link
Member

No description provided.

@Blackbaud-PaulCrowder
Copy link
Member Author

blackbaud/skyux2#419

@codecov-io
Copy link

Codecov Report

Merging #330 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #330   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          61     62    +1     
  Lines        1453   1512   +59     
  Branches      228    234    +6     
=====================================
+ Hits         1453   1512   +59
Flag Coverage Δ
#builder 100% <100%> (ø) ⬆️
#runtime 100% <ø> (ø) ⬆️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cli/generate.js 100% <100%> (ø)
index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939db63...c2b0db4. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Nov 13, 2017

Codecov Report

Merging #330 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #330   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          61     62    +1     
  Lines        1450   1509   +59     
  Branches      228    234    +6     
=====================================
+ Hits         1450   1509   +59
Flag Coverage Δ
#builder 100% <100%> (ø) ⬆️
#runtime 100% <ø> (ø) ⬆️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
index.js 100% <100%> (ø) ⬆️
cli/generate.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e9390...cfcfeb7. Read the comment docs.

@Blackbaud-BobbyEarl
Copy link

LGTM. General discussion which I wouldn't necessarily consider non-blocking feedback.

Is there an opportunity to combine this functionality with skyux new. Perhaps either by running this command as part of the skyux new process, so that a new site will always contain the latest example of a component.

Or perhaps flip that, and keep the logic here but have it pull the source files from the template?

Copy link

@Blackbaud-BobbyEarl Blackbaud-BobbyEarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a comment regarding architecture of feature.

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder merged commit 62cc222 into master Nov 14, 2017
@Blackbaud-PaulCrowder Blackbaud-PaulCrowder deleted the generate-component branch November 14, 2017 21:24
@Blackbaud-PaulCrowder
Copy link
Member Author

I think it makes sense to try to keep the generated components and the boilerplate components in the template in sync. I'm not exactly sure what the right approach is, though. Let's keep thinking about it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants