-
Notifications
You must be signed in to change notification settings - Fork 28
Added ability to generate a component from the CLI #330
Conversation
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 61 62 +1
Lines 1453 1512 +59
Branches 228 234 +6
=====================================
+ Hits 1453 1512 +59
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 61 62 +1
Lines 1450 1509 +59
Branches 228 234 +6
=====================================
+ Hits 1450 1509 +59
Continue to review full report at Codecov.
|
LGTM. General discussion which I wouldn't necessarily consider non-blocking feedback. Is there an opportunity to combine this functionality with Or perhaps flip that, and keep the logic here but have it pull the source files from the template? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a comment regarding architecture of feature.
I think it makes sense to try to keep the generated components and the boilerplate components in the template in sync. I'm not exactly sure what the right approach is, though. Let's keep thinking about it. |
No description provided.