This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fixed a bug preventing navigation via omnibar due to loading outside Angular #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-PaulCrowder
requested review from
Blackbaud-BobbyEarl and
Blackbaud-SteveBrush
src/app/app.component.ts
Outdated
| @@ -156,11 +156,18 @@ export class AppComponent implements OnInit { | |||
| } | |||
|
|
|||
| nav.beforeNavCallback = (item: BBOmnibarNavigationItem) => { | |||
| console.log(baseUrl); | |||
There was a problem hiding this comment.
Good catch.
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 61 61
Lines 1453 1454 +1
Branches 228 228
=====================================
+ Hits 1453 1454 +1
Continue to review full report at Codecov.
|
Blackbaud-BobbyEarl
approved these changes
Nov 13, 2017
Blackbaud-MikitaYankouski
pushed a commit
to Blackbaud-MikitaYankouski/skyux-builder
that referenced
this pull request
May 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes blackbaud/skyux2#1286