Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Faster build #340

Merged
merged 7 commits into from
Nov 17, 2017
Merged

Faster build #340

merged 7 commits into from
Nov 17, 2017

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented Nov 17, 2017

Turns out the build was pulling from node_modules, which is why it was so slow. There are a few other updates I'd like to make, but this should do for now.

This UX pull request is referencing this branch:
blackbaud/skyux2#1294

@codecov-io
Copy link

codecov-io commented Nov 17, 2017

Codecov Report

Merging #340 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #340   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          62     62           
  Lines        1509   1510    +1     
  Branches      234    234           
=====================================
+ Hits         1509   1510    +1
Flag Coverage Δ
#builder 100% <100%> (ø) ⬆️
#runtime 100% <ø> (ø) ⬆️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cli/build.js 100% <ø> (ø) ⬆️
config/webpack/common.webpack.config.js 100% <ø> (ø) ⬆️
config/webpack/build-aot.webpack.config.js 100% <ø> (ø) ⬆️
lib/sky-pages-module-generator.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e3a3a3...cc900a2. Read the comment docs.

@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title [HOLD] Faster build Faster build Nov 17, 2017
@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title Faster build [HOLD] Faster build Nov 17, 2017
@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title [HOLD] Faster build Faster build Nov 17, 2017
@Blackbaud-SteveBrush
Copy link
Member Author

@Blackbaud-BobbyEarl Alright, this is finally ready for review.

loader: outPath('loader', 'sky-app-config')
test: /config\.ts$/,
loader: outPath('loader', 'sky-app-config'),
include: outPath('runtime')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious about the different syntax here.

Copy link
Member Author

@Blackbaud-SteveBrush Blackbaud-SteveBrush Nov 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will ONLY look in the root's runtime folder, instead of "any" runtime folder.

Copy link
Member Author

@Blackbaud-SteveBrush Blackbaud-SteveBrush Nov 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, @Blackbaud-BobbyEarl it's recommended by Webpack docs to be more specific with loaders. https://webpack.js.org/guides/build-performance/#loaders

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit e5b61c8 into master Nov 17, 2017
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the faster-build branch November 17, 2017 15:51
Blackbaud-MikitaYankouski pushed a commit to Blackbaud-MikitaYankouski/skyux-builder that referenced this pull request May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants