-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 62 62
Lines 1509 1510 +1
Branches 234 234
=====================================
+ Hits 1509 1510 +1
Continue to review full report at Codecov.
|
@Blackbaud-BobbyEarl Alright, this is finally ready for review. |
loader: outPath('loader', 'sky-app-config') | ||
test: /config\.ts$/, | ||
loader: outPath('loader', 'sky-app-config'), | ||
include: outPath('runtime') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious about the different syntax here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will ONLY look in the root's runtime folder, instead of "any" runtime folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, @Blackbaud-BobbyEarl it's recommended by Webpack docs to be more specific with loaders. https://webpack.js.org/guides/build-performance/#loaders
Turns out the build was pulling from node_modules, which is why it was so slow. There are a few other updates I'd like to make, but this should do for now.
This UX pull request is referencing this branch:
blackbaud/skyux2#1294