Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Added support for reading locale from SKYUX_HOST global variable #345

Merged
merged 3 commits into from
Jan 17, 2018

Conversation

Blackbaud-PaulCrowder
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 7, 2017

Codecov Report

Merging #345 into master will decrease coverage by 0.77%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
- Coverage     100%   99.22%   -0.78%     
==========================================
  Files          65       71       +6     
  Lines        1631     1671      +40     
  Branches      254      260       +6     
==========================================
+ Hits         1631     1658      +27     
- Misses          0       13      +13
Flag Coverage Δ
#builder 100% <ø> (ø) ⬆️
#runtime 94.11% <100%> (-5.89%) ⬇️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
lib/sky-pages-module-generator.js 100% <ø> (ø) ⬆️
runtime/i18n/locale-provider.ts 100% <ø> (ø) ⬆️
runtime/i18n/resources.service.ts 100% <100%> (ø) ⬆️
runtime/i18n/host-locale-provider.ts 100% <100%> (ø)
runtime/search-results-provider.ts 100% <0%> (ø)
runtime/omnibar-provider.ts 100% <0%> (ø)
runtime/pact-auth-token-provider.ts 75% <0%> (ø)
runtime/pact.service.ts 41.17% <0%> (ø)
runtime/viewport.service.ts 50% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75c0c44...2728ca3. Read the comment docs.

@Blackbaud-BobbyEarl
Copy link

Hey @Blackbaud-PaulCrowder is this ready for review?

@Blackbaud-PaulCrowder
Copy link
Member Author

I believe so.

Copy link

@Blackbaud-BobbyEarl Blackbaud-BobbyEarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also took a first-stab at documenting this feature via blackbaud/skyux2-docs#15

@Blackbaud-BobbyEarl Blackbaud-BobbyEarl merged commit 65047c6 into master Jan 17, 2018
@Blackbaud-BobbyEarl Blackbaud-BobbyEarl deleted the default-locale-provider branch January 17, 2018 18:42
Blackbaud-MikitaYankouski pushed a commit to Blackbaud-MikitaYankouski/skyux-builder that referenced this pull request May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants