This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Disabling standalone install for webdriver manager #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 65 65
Lines 1631 1631
Branches 254 254
=====================================
Hits 1631 1631
Continue to review full report at Codecov.
|
Blackbaud-SteveBrush
requested review from
Blackbaud-BobbyEarl,
Blackbaud-TerryHelems and
blackbaud-brandonhare
blackbaud-brandonhare
approved these changes
Dec 18, 2017
Blackbaud-BobbyEarl
approved these changes
Jan 9, 2018
Blackbaud-MikitaYankouski
pushed a commit
to Blackbaud-MikitaYankouski/skyux-builder
that referenced
this pull request
May 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: blackbaud/skyux2#1370
SPA now passing:
https://blackbaud.visualstudio.com/Products/_build/index?buildId=456209&_a=summary
Works on the Browserstack SPA as well:
https://blackbaud.visualstudio.com/Products/_build/index?buildId=456217&_a=summary
@Blackbaud-BobbyEarl: So this inadvertently started working again. Originally, the issue only occurred when trying to download the "standalone" JAR from the remote (setting
--standalone falsefixed the issue at the time). After a few hours, the remote server was working again. At any rate, would this change still be appropriate, since we aren't specifically running standalone, but executing e2e directly against the Chrome driver?