Added test utility from SKY UX #382
Conversation
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
=======================================
Coverage 99.25% 99.25%
=======================================
Files 71 71
Lines 1741 1741
Branches 283 283
=======================================
Hits 1728 1728
Misses 13 13
Continue to review full report at Codecov.
|
Blackbaud-SteveBrush
requested review from
Blackbaud-BobbyEarl and
Blackbaud-PaulCrowder
| @@ -0,0 +1,23 @@ | |||
| export interface SkyAppTestUtilityEventArgs { | |||
There was a problem hiding this comment.
I think I'd call this SkyAppTestUtilityEventOptions instead. Ending a class name with EventArgs is a common pattern for classes used to pass arguments into an event handler, which is not the case here. I'd also move it to a separate file so we're only exporting one type from this file.
| public static fireDomEvent( | ||
| element: EventTarget, | ||
| eventName: string, | ||
| args?: SkyAppTestUtilityEventArgs |
There was a problem hiding this comment.
Remember to change this parameter name to match the new class name.
| cancelable?: boolean; | ||
| } | ||
|
|
||
| function getWindow() { |
There was a problem hiding this comment.
I'm not sure I understand the purpose of this function. I could see if maybe you wanted to mock out the window object you'd want to do something like this, but it's not possible with the code as it is.
* Added test utility from SKY UX * Separated event options into separate file
No description provided.