Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Add ability to import individual SKY UX modules #383

Merged
merged 1 commit into from
Mar 29, 2018

Conversation

Blackbaud-PaulCrowder
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 28, 2018

Codecov Report

Merging #383 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   99.25%   99.25%   +<.01%     
==========================================
  Files          71       71              
  Lines        1740     1741       +1     
  Branches      282      283       +1     
==========================================
+ Hits         1727     1728       +1     
  Misses         13       13
Flag Coverage Δ
#builder 100% <100%> (ø) ⬆️
#runtime 94.75% <ø> (ø) ⬆️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
runtime/config.ts 100% <ø> (ø) ⬆️
utils/runtime-test-utils.js 100% <ø> (ø) ⬆️
lib/sky-pages-module-generator.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52df752...c76ad6c. Read the comment docs.

@Blackbaud-SteveBrush
Copy link
Member

Looks good to me! Only concern I would have is the legacy config that some SPAs will have once we split up the libraries and this feature becomes deprecated. But I suppose there might be other properties in the config that will change too, so not a huge deal.

@Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-PaulCrowder: Also, it appears that every module combination I tried required the SkyErrorModule; not sure if it's worth adding that one in no matter what. See:

const err = `<sky-error errorType="notfound"></sky-error>`;

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder merged commit 4688d33 into master Mar 29, 2018
@Blackbaud-PaulCrowder Blackbaud-PaulCrowder deleted the skyux-module-import-config branch March 29, 2018 14:10
Blackbaud-MikitaYankouski pushed a commit to Blackbaud-MikitaYankouski/skyux-builder that referenced this pull request May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants