This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
RC > Removed SKY CSS import #443
Merged
+29
−142
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
785458a
Removed SKY CSS import
Blackbaud-SteveBrush b931678
Updated style loader
Blackbaud-SteveBrush 121f7ce
Merge branch 'rc-2.0.0' into rc-remove-sky-css
Blackbaud-SteveBrush 5d5cddf
Added skyux-theme
Blackbaud-SteveBrush 12bdff9
Updated reference to style loader
Blackbaud-SteveBrush d401b76
Removed jasmine style loader
Blackbaud-SteveBrush 6319757
Removed style loaders
Blackbaud-SteveBrush 97e8b26
Fixed unit tests
Blackbaud-SteveBrush 2fb8f55
Updated theme version
Blackbaud-SteveBrush a3d24c2
Added unit test for viewport service
Blackbaud-SteveBrush 4827483
Updated range for skyux theme package
Blackbaud-SteveBrush File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had quite a few comments typed up before I realized this file is different from https://github.com/blackbaud/skyux-builder/blob/master/runtime/style-loader.ts
For clarification, this file is only called from https://github.com/blackbaud/skyux-builder/blob/19943499ea387f11965c6ccb9c4d35d6cc973f22/utils/spec-styles.js? and
spec-styles
is used at https://github.com/blackbaud/skyux-builder/blob/master/config/karma/shared.karma.conf.js?If this is the case, and we're removing the automated loading of the Blackbaud Sans font, I wonder should we instead just remove the
blackbaudSans.load()
call?Tangentially related, should we do the same thing to the runtime side?