Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Adopt @skyux/theme #458

Merged
merged 5 commits into from
Aug 27, 2018
Merged

Adopt @skyux/theme #458

merged 5 commits into from
Aug 27, 2018

Conversation

Blackbaud-SteveBrush
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 23, 2018

Codecov Report

Merging #458 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
+ Coverage   99.32%   99.42%   +0.09%     
==========================================
  Files          73       71       -2     
  Lines        1931     1914      -17     
  Branches      305      305              
==========================================
- Hits         1918     1903      -15     
+ Misses         13       11       -2
Flag Coverage Δ
#builder 100% <100%> (ø) ⬆️
#runtime 96.05% <ø> (+0.44%) ⬆️
#srcapp 100% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/app/app.component.ts 100% <100%> (ø) ⬆️
config/webpack/alias-builder.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e9403b...07f3794. Read the comment docs.

package.json Outdated
@@ -50,6 +50,7 @@
"@pact-foundation/pact": "5.3.0",
"@pact-foundation/pact-node": "6.7.0",
"@pact-foundation/pact-web": "5.3.0",
"@skyux/theme": "3.0.0-alpha.9",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added as a dependency to make the tests pass, but it should be removed once it's added as a dependency of SKY UX.
See: blackbaud/skyux2#1930

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 45b2935 into master Aug 27, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the adopt-skyux-theme branch August 27, 2018 14:22
Blackbaud-MikitaYankouski pushed a commit to Blackbaud-MikitaYankouski/skyux-builder that referenced this pull request May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants