Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Added plugins hook to library bundler #469

Merged
merged 3 commits into from
Sep 13, 2018

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented Sep 12, 2018

  • This will allow plugins to affect the skyux build-public-library phase.
  • Needed to accommodate the synchronous nature of SkyResources service.

This is being used, here: blackbaud/skyux-core#31

@@ -6,7 +6,7 @@ environment:
nodejs_version: "6"

install:
- choco install googlechrome
- choco install googlechrome --ignore-checksums
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-io
Copy link

Codecov Report

Merging #469 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
+ Coverage   99.42%   99.42%   +<.01%     
==========================================
  Files          71       71              
  Lines        1914     1918       +4     
  Branches      305      305              
==========================================
+ Hits         1903     1907       +4     
  Misses         11       11
Flag Coverage Δ
#builder 100% <100%> (ø) ⬆️
#runtime 95.98% <ø> (ø) ⬆️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cli/build-public-library.js 100% <100%> (ø) ⬆️
lib/plugin-file-processor.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b98dc88...aa1c386. Read the comment docs.

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 2ba80bd into master Sep 13, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the plugins-for-libraries branch September 13, 2018 15:13
@Blackbaud-SteveBrush Blackbaud-SteveBrush restored the plugins-for-libraries branch September 13, 2018 15:13
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the plugins-for-libraries branch October 4, 2018 15:46
Blackbaud-MikitaYankouski pushed a commit to Blackbaud-MikitaYankouski/skyux-builder that referenced this pull request May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants