Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Libraries > Fixed transpile source path #474

Merged
merged 2 commits into from
Sep 20, 2018

Conversation

Blackbaud-SteveBrush
Copy link
Member

Currently, our SCSS compiler and HTML template injector is looking in ./src/app/public/src, but it should be looking in ./src/app/public.

Essentially, if a TS component is NOT located in ./src/app/public/src, it won't statically inject SCSS and HTML contents.

@codecov-io
Copy link

codecov-io commented Sep 20, 2018

Codecov Report

Merging #474 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #474   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          71       71           
  Lines        1924     1924           
  Branches      306      306           
=======================================
  Hits         1913     1913           
  Misses         11       11
Flag Coverage Δ
#builder 100% <100%> (ø) ⬆️
#runtime 95.98% <ø> (ø) ⬆️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cli/utils/stage-library-ts.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4d549...c534583. Read the comment docs.

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 4e9c350 into master Sep 20, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the fix-library-transpile-src branch September 20, 2018 17:56
Blackbaud-MikitaYankouski pushed a commit to Blackbaud-MikitaYankouski/skyux-builder that referenced this pull request May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants