This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Using different technique to ignore changes. #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 54 54
Lines 1682 1686 +4
Branches 250 249 -1
=====================================
+ Hits 1682 1686 +4
Continue to review full report at Codecov.
|
added 2 commits
October 25, 2018 10:34
…ux-builder into skyux-watch-ignore
Blackbaud-BobbyEarl
changed the title
| // Returning `true` means the file should be ignored. | ||
| // Fat-Arrow functions do not work as chokidar will inspect this method. | ||
| ignored: function (item) { | ||
| const resolvedPath = path.resolve(item); |
There was a problem hiding this comment.
We need to resolve the path because Webpack will provide both of these values:
C:\Users\stevebr\Projects\github\blackbaud\skyux-i18n\src\app\app-extras.module.ts
C:/Users/stevebr/Projects/github/blackbaud/skyux-i18n/src/app/app-extras.module.ts
Blackbaud-SteveBrush
previously approved these changes
Oct 30, 2018
Blackbaud-BobbyEarl
changed the title
Blackbaud-BobbyEarl
dismissed
Blackbaud-SteveBrush’s stale review
via
f35b34b
Blackbaud-SteveBrush
approved these changes
Oct 30, 2018
| } | ||
| }); | ||
| } | ||
| spawnResult.output.forEach((buffer) => { |
There was a problem hiding this comment.
For clarification, this was incorrectly added in a previous PR due to a misconfigured unit test.
Blackbaud-MikitaYankouski
pushed a commit
to Blackbaud-MikitaYankouski/skyux-builder
that referenced
this pull request
May 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: blackbaud/skyux2#2134