Use the remapped code coverage summary for code coverage threshold check #499
Conversation
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 54 54
Lines 1686 1711 +25
Branches 249 254 +5
=====================================
+ Hits 1686 1711 +25
Continue to review full report at Codecov.
|
config/karma/shared.karma.conf.js
Outdated
| return remapIstanbul.remap(collector.getFinalCoverage()); | ||
| const newCollector = remapIstanbul.remap(collector.getFinalCoverage()); | ||
|
|
||
| if (!remapCoverageSummary) { |
There was a problem hiding this comment.
Any concern on how this might affect multiple browsers? My concern is that the first result will be returned for all subsequent calls, even though they may be different browsers with different coverage.
config/karma/shared.karma.conf.js
Outdated
| 'functions' | ||
| ]; | ||
|
|
||
| const threshold = getCoverageThreshold(skyPagesConfig); |
There was a problem hiding this comment.
I don’t believe this line is needed twice.
config/karma/shared.karma.conf.js
Outdated
|
|
||
| let coverageFailed; | ||
|
|
||
| keys.forEach(function (key) { |
There was a problem hiding this comment.
Any reason to not use fat arrow here?
…alled during `watch`
…kbaud/skyux-builder into code-coverage-threshold-fix
|
@Blackbaud-BobbyEarl This should be ready for another look. |
|
Ha, guess I should've checked that I reviewed this yesterday. D'oh. |
…eck (blackbaud#499) * Use the remapped code coverage summary for code coverage threshold check * Fixed lint rule * Unit tests * Removed redundant const * Validate that done() called * Be explicit about whether test should pass coverage threshold check * Fixed lint error * Report coverage inside _onWriteReport() since _onExit() doesn't get called during `watch` * Minor refactoring * Fixed linting error. * Use function expression for consistency * Changed `let` to`const` where appropriate
No description provided.