Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Checking if files exists before writing in generate. Allowing --force/-f to bypass. #500

Merged
merged 4 commits into from
Dec 4, 2018

Conversation

Blackbaud-BobbyEarl
Copy link

@codecov-io
Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #500 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #500   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          54     54           
  Lines        1711   1724   +13     
  Branches      254    257    +3     
=====================================
+ Hits         1711   1724   +13
Flag Coverage Δ
#builder 100% <100%> (ø) ⬆️
#runtime 100% <ø> (ø) ⬆️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cli/generate.js 100% <100%> (ø) ⬆️
index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9701811...d45847a. Read the comment docs.

@blackbaud-johnly
Copy link
Contributor

Created blackbaud/skyux2#2199 to document the new flags

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comment. LGTM.

cli/generate.js Outdated Show resolved Hide resolved
@Blackbaud-BobbyEarl Blackbaud-BobbyEarl merged commit e29d5a3 into master Dec 4, 2018
@Blackbaud-BobbyEarl Blackbaud-BobbyEarl deleted the generate-exists branch December 4, 2018 14:01
Blackbaud-MikitaYankouski pushed a commit to Blackbaud-MikitaYankouski/skyux-builder that referenced this pull request May 3, 2019
…/-f to bypass. (blackbaud#500)

* Checking if files exists before writing in generate.  Allowing force to bypass.

* Allowing shortcut force.

* Fixed linting error.

* Fixed linting suggestions.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants