-
Notifications
You must be signed in to change notification settings - Fork 5
Default to concise logging. Support --name and --repo flags for skyux new
.
#158
Conversation
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 8 8
Lines 265 292 +27
Branches 40 45 +5
=====================================
+ Hits 265 292 +27
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming we only want to add this feature to the CLI (and not @blackbaud/skyux-logger
) this looks and works great.
Hey @Blackbaud-SteveBrush, I'm overloading this PR. I just updated to add support for |
I thought about your question @Blackbaud-SteveBrush. My vote would be to introduce it here as a one-off. If we find we like it, or actually have a need for it, it would be easy enough to move that logic into the logger. |
skyux new
.
As first suggested, @Blackbaud-SteveBrush, I've moved the ora logic into a new This PR should be updated to point to that released version, as I'm temporarily pointing to the branch. |
'SPA root directories may only contain lower-case letters, numbers or dashes.' | ||
); | ||
throw new Error(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is throwing an empty error a requirement to fail the process? Could we not process.exit(1)
? Just seemed odd to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, my console printed the following:
$ skyux new --name FOOBAR
SKY UX processing command new
SPA root directories may only contain lower-case letters, numbers or dashes.
ERROR MESSAGE
See "ERROR MESSAGE". It also proceeded to the next step of the process instead of exiting. Is that accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ERROR MESSAGE
was a rogue console.log
hanging out. I'll remove that silly thing.
When you say "proceeded to the next step," can you confirm you see "What is the root directory for your SPA? (example: my-spa-name)" displayed. That's actually the first step, which is bypassed by passing in the name
argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The throw new Error()
is necessary to have the validator of the prompt
library fail.
More changes were added since the last review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature works great. Aside from our conversation about the "name" vs "root directory" messaging, this LGTM.
Created blackbaud/skyux2#2195 to document the new flags |
No description provided.