This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fix validation to fire for user input #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-SteveBrush
requested a review
from Blackbaud-AlexKingman
as a code owner
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 25 25
Lines 1294 1291 -3
Branches 194 194
=====================================
- Hits 1294 1291 -3
Continue to review full report at Codecov.
|
|
When changing from an invalid state to a valid state, the red border does not go away. See screenshot: |
Blackbaud-SteveBrush
dismissed
Blackbaud-TrevorBurch’s stale review
via
5e8942f
|
@Blackbaud-AlexKingman Ready for another look. |
| @@ -1,4 +1,4 @@ | |||
| export const enum SkyDateRangeCalculatorType { | |||
| export enum SkyDateRangeCalculatorType { | |||
There was a problem hiding this comment.
Adding const was causing this enum to return an empty value. I'm guessing it has something to do with our version of TypeScript. At any rate, removing the const fixes the problem.
Blackbaud-AlexKingman
approved these changes
Apr 25, 2019
Blackbaud-TrevorBurch
approved these changes
Apr 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation works fine when the initial value is set in the
FormControl, or if the value is written programmatically to theformControlNameafter the fact, but validation doesn't work when manually selecting dates from the date pickers. This PR addresses that problem.To test, serve the
masterbranch and select "Specific range" and then deliberately choose an end date that comes before a start date to NOT see the expected error.