Fixed calendar weekdays not being static

[Blackbaud-TrevorBurch]

No description provided.

[Blackbaud-SteveBrush]

What do you think about setting the default in the calendar component, so that if undefined is passed (or set) from on-high, it will always resolve to zero when it reaches the calendar.

https://github.com/blackbaud/skyux-datetime/blob/master/src/app/public/modules/datepicker/datepicker-calendar.component.ts#L34

[Blackbaud-SteveBrush]

The calendar component has its own spec, too.

[Blackbaud-TrevorBurch]

Good call. Done.

I also noticed that with what I had that if the user actually bound to undefined we would still use that. My new version uses a getter/setter in order to ensure we use "0" if undefined is passed in.

You also may notice that I no longer have a test around this. This is because we really already had a test for this (line 131 of the datepicker-calendar spec); however, it was passing before because our test component was setting 0 by default. I have changed the test component to not send in a value unless specifically set in a test (which we do have 2 tests doing this).

[codecov]

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #41   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          26     26           
  Lines        1311   1314    +3     
  Branches      199    200    +1     
=====================================
+ Hits         1311   1314    +3

Impacted Files	Coverage Δ
...odules/datepicker/datepicker-calendar.component.ts	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c496662...6d7b9a3. Read the comment docs.

[Blackbaud-SteveBrush]

Is there already a unit test to confirm that the starting day defaults to zero?

[Blackbaud-TrevorBurch]

Is there already a unit test to confirm that the starting day defaults to zero?

Yup. See my comment on your last comment. There was already one but the test component was manually setting the 0. I removed that piece so that the test would now test this situation and there are other tests that test when it is manually set.