Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update text colors to pass a11y color contrast rule #24

Merged
merged 3 commits into from
Jan 4, 2019
Merged

Update text colors to pass a11y color contrast rule #24

merged 3 commits into from
Jan 4, 2019

Conversation

Blackbaud-SteveBrush
Copy link
Member

No description provided.

Blackbaud-ToddRoberts
Blackbaud-ToddRoberts requested changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@Blackbaud-ToddRoberts Blackbaud-ToddRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of not changing existing variable values, I think we should add a 105 gray and 75 blue, and point existing variables that reference the 100/70 variables to the new 105/75.

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 0cfc7c5 into master Jan 4, 2019
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the a11y-colors branch January 4, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blackbaud-ToddRoberts Blackbaud-ToddRoberts Blackbaud-ToddRoberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Blackbaud-SteveBrush @Blackbaud-ToddRoberts