Implemented flyout closure on navigation. #22
Conversation
Blackbaud-TrevorBurch
requested review from
Blackbaud-AlexKingman and
Blackbaud-SteveBrush
as code owners
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 99.71% 99.72% +<.01%
==========================================
Files 10 10
Lines 351 358 +7
Branches 52 54 +2
==========================================
+ Hits 350 357 +7
Misses 1 1
Continue to review full report at Codecov.
|
* added navigate button to demo * reverted old code * removed baselines
There was a problem hiding this comment.
We had a problem when we added this same feature to the modal host component. People that were testing their components (that also implemented the modal component/service) were getting new errors saying Router is not provided. It might be worth double-checking that a component fixture that implements the flyout (in another consuming SPA) doesn't throw this error during skyux test.
There was a problem hiding this comment.
Also, since we're removing the screenshots, now would be a good time to implement the screenshotName property in the e2e tests. I'm seeing the following warnings in the logs:
A unique screenshot name was not provided!
We'll use "body0" as a stand-in, but this can cause problems if you decide to change the order of the specs in the future. To set the screenshot name for each test, add a config object to the matcher:
`expect('.foobar').toMatchBaselineScreenshot(done, { screenshotName: 'unique-name' });`
|
Good call on the screenshot names @Blackbaud-SteveBrush that is done :) |
Addresses blackbaud/skyux-flyout#20