Added sticky settings functionality to flyout #53
Conversation
Blackbaud-TrevorBurch
requested review from
Blackbaud-AlexKingman and
Blackbaud-SteveBrush
as code owners
…to sticky-settings and resolved conflict
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 452 474 +22
Branches 74 78 +4
=====================================
+ Hits 452 474 +22
Continue to review full report at Codecov.
|
| { | ||
| flyoutWidth: this.flyoutWidth | ||
| } | ||
| ).subscribe( |
There was a problem hiding this comment.
Needs a takeUntil().
There was a problem hiding this comment.
Added a take(1)
| fixture.detectChanges(); | ||
| tick(); | ||
| spyOn(SkyFlyoutComponent.prototype, 'onMouseMove').and.callThrough(); | ||
| spyOn(SkyFlyoutComponent.prototype, 'onHandleRelease').and.callThrough(); |
There was a problem hiding this comment.
Why are you spying on these two mouse events? I don't see you utilizing them anywhere...
There was a problem hiding this comment.
There were two tests like this due to copy pasta. I've fixed them both.
|
@Blackbaud-AlexKingman ready for you again. I changed how min and max detection happens so that we no longer check for that until after we grab the sticky settings. There was also some bugginess with timing with the sticky settings - these changes fix that. |
No description provided.