This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Sky 3 upgrade #56
Merged
Sky 3 upgrade #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-TrevorBurch
requested review from
Blackbaud-AlexKingman and
Blackbaud-SteveBrush
as code owners
package.json
Outdated
| "@skyux/core": "^3.5.1", | ||
| "@skyux/i18n": "^3.5.0", | ||
| "@skyux/indicators": "^3.0.0" | ||
| "@skyux-sdk/builder": "^3.7.0", |
There was a problem hiding this comment.
Looks like the migration added some peers.
There was a problem hiding this comment.
I fixed this :)
| @@ -20,7 +20,8 @@ import { | |||
| } from '@skyux-sdk/testing'; | |||
|
|
|||
| import { | |||
| Observable | |||
| Observable, | |||
| throwError | |||
There was a problem hiding this comment.
We can't migrate to RxJS 6 just yet, because it wouldn't work with SKY UX 2 SPAs.
There was a problem hiding this comment.
I've reverted to the correct import for compatibility and have added a note to do the change later
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 474 478 +4
Branches 78 65 -13
=====================================
+ Hits 474 478 +4
Continue to review full report at Codecov.
|
Blackbaud-SteveBrush
approved these changes
Jun 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://github.com/blackbaud/skyux-flyout/issues/58