Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Implemented the use of the SkyDynamicComponentService #9

Merged
merged 4 commits into from
Dec 20, 2018

Conversation

Blackbaud-TrevorBurch
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 18, 2018

Codecov Report

Merging #9 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #9      +/-   ##
========================================
+ Coverage   99.71%   100%   +0.28%     
========================================
  Files          10     10              
  Lines         350    338      -12     
  Branches       53     52       -1     
========================================
- Hits          349    338      -11     
+ Misses          1      0       -1
Impacted Files Coverage Δ
...pp/public/modules/flyout/flyout-adapter.service.ts 100% <ø> (ø) ⬆️
src/app/public/modules/flyout/flyout.module.ts 100% <ø> (ø) ⬆️
src/app/public/modules/flyout/flyout.service.ts 100% <100%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa8a51c...6e6cdbb. Read the comment docs.

@Blackbaud-AlexKingman
Copy link
Contributor

@Blackbaud-TrevorBurch what about these items in flyout.component.ts?

    private adapter: SkyFlyoutAdapterService,
    private changeDetector: ChangeDetectorRef,
    private injector: Injector,
    private resolver: ComponentFactoryResolver

@Blackbaud-AlexKingman Blackbaud-AlexKingman self-assigned this Dec 18, 2018
@Blackbaud-TrevorBurch
Copy link
Member Author

@Blackbaud-AlexKingman the dynamic service only adds things to the top and bottom of the body. Those imports are used for rendering the consumer's passed in components in the flyout host which is not supported by the dynamic service. If we wanted to have that functionality we would need another enhancement to the dynamic service.

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes to the service unit test work well, but we definitely need to come back later on and mock everything out a little better.
https://angular.io/guide/testing#service-tests

src/app/public/modules/flyout/flyout.component.spec.ts Outdated Show resolved Hide resolved
@Blackbaud-TrevorBurch Blackbaud-TrevorBurch merged commit 6ba8717 into master Dec 20, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the dynamic-component-adoption branch December 20, 2018 20:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants