-
Notifications
You must be signed in to change notification settings - Fork 3
Implemented the use of the SkyDynamicComponentService #9
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
========================================
+ Coverage 99.71% 100% +0.28%
========================================
Files 10 10
Lines 350 338 -12
Branches 53 52 -1
========================================
- Hits 349 338 -11
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
@Blackbaud-TrevorBurch what about these items in
|
@Blackbaud-AlexKingman the dynamic service only adds things to the top and bottom of the body. Those imports are used for rendering the consumer's passed in components in the flyout host which is not supported by the dynamic service. If we wanted to have that functionality we would need another enhancement to the dynamic service. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes to the service unit test work well, but we definitely need to come back later on and mock everything out a little better.
https://angular.io/guide/testing#service-tests
…to dynamic-component-adoption
No description provided.