Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Adopt SkyUIConfigService #31

Merged
merged 6 commits into from
Jan 16, 2019
Merged

Adopt SkyUIConfigService #31

merged 6 commits into from
Jan 16, 2019

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented Jan 11, 2019

Addresses: https://github.com/blackbaud/skyux-grids/issues/30


How to test

  • Clone the repo and checkout the branch
  • Type npm i --no-save @blackbaud-internal/skyux-lib-ui-config-service
  • Open skyuxconfig.json and set name to "email" and auth to true.
  • Open app-extras.module.ts and import the following:
import { SkyUIConfigService } from '@skyux/core';
import { SkyAppUIConfigService } from '@blackbaud-internal/skyux-lib-ui-config-service';
  • Open app-extras.module.ts and add the following provider:
{
  provide: SkyUIConfigService,
  useClass: SkyAppUIConfigService
}
  • Open grid-visual.component.html and add the attribute settingsKey="new-email-designer" to the <sky-grid> component.
  • Serve the SPA.
  • Change the order of the grid's columns and refresh the page. The order should be preserved.

@codecov-io
Copy link

codecov-io commented Jan 14, 2019

Codecov Report

Merging #31 into master will increase coverage by 0.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #31     +/-   ##
=========================================
+ Coverage    99.4%   99.81%   +0.4%     
=========================================
  Files          10       10             
  Lines         508      542     +34     
  Branches       74       82      +8     
=========================================
+ Hits          505      541     +36     
+ Misses          3        1      -2
Impacted Files Coverage Δ
src/app/public/modules/grid/grid.component.ts 100% <100%> (+0.54%) ⬆️
src/app/public/modules/grid/grid.module.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d478259...4ec6ca6. Read the comment docs.

Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 161e2d9 into master Jan 16, 2019
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the ui-config branch January 16, 2019 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants