Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Resize column > touch support #57

Merged
merged 4 commits into from
May 20, 2019

Conversation

Blackbaud-AlexKingman
Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman commented May 20, 2019

Addresses #40

@Blackbaud-AlexKingman Blackbaud-AlexKingman changed the title Resize col touch support Resize column > touch support May 20, 2019
@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #57 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   99.81%   99.81%   +<.01%     
==========================================
  Files          10       10              
  Lines         550      555       +5     
  Branches       85       85              
==========================================
+ Hits          549      554       +5     
  Misses          1        1
Impacted Files Coverage Δ
src/app/public/modules/grid/grid.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9e5c25...9bc900e. Read the comment docs.

Copy link
Member

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Blackbaud-AlexKingman should we have some unit tests around this that looks for the touch event instead of the mouse event like previous unit tests would have? That way if we accidentally break this in the future we will now about it.

@Blackbaud-AlexKingman Blackbaud-AlexKingman merged commit b7b32ab into master May 20, 2019
@Blackbaud-AlexKingman Blackbaud-AlexKingman deleted the resize-col-touch-support branch May 20, 2019 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants