Do not allow for reordering locked column via sort selector #71
Conversation
…ide of a locked column.
Blackbaud-TrevorBurch
requested review from
Blackbaud-AlexKingman and
Blackbaud-SteveBrush
as code owners
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 99.82% 99.82% +<.01%
==========================================
Files 10 10
Lines 568 570 +2
Branches 81 83 +2
==========================================
+ Hits 567 569 +2
Misses 1 1
Continue to review full report at Codecov.
|
| undefined, | ||
| const moveOptionValid = options.moves( | ||
| { | ||
| querySelector(selector: string) { |
There was a problem hiding this comment.
should querySelector and matches be the same? I would expect querySelector to either return the selector or the selected element
There was a problem hiding this comment.
Ya. You're right. I honestly was just returning something true/false for the test but looking at it again that doesn't make much sense. I should at least return an element (even if mocked) so that it makes more sense for someone later. I'll fix that.
|
Manual tests look good. Other than Erika's comment, this LGTM. |
No description provided.