This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Properly disable dragging on and left of a locked column #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-TrevorBurch
requested review from
Blackbaud-AlexKingman and
Blackbaud-SteveBrush
as code owners
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 99.82% 99.82% +<.01%
==========================================
Files 10 10
Lines 570 585 +15
Branches 83 87 +4
==========================================
+ Hits 569 584 +15
Misses 1 1
Continue to review full report at Codecov.
|
| const siblingDiv = sibling.querySelector('div'); | ||
| let isLeftOfLocked = false; | ||
|
|
||
| for (let i = (columns.length - 1); i >= 0; i--) { |
There was a problem hiding this comment.
Any chance we could encapsulate this logic so its not repeated? Maybe something named isLeftOfLocked() that returns a boolean?
There was a problem hiding this comment.
@Blackbaud-AlexKingman done.
| }); | ||
| } | ||
|
|
||
| public setStyle(el: ElementRef, style: string, value: string): void { | ||
| this.renderer.setStyle(el.nativeElement, style, value); | ||
| } | ||
|
|
||
| private isLeftOfLocked(sourceColumn: HTMLElement, columns: NodeListOf<Element>) { |
There was a problem hiding this comment.
Needs return type :)
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.