Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Recalculate table width when columns are shown/hidden #8

Merged
merged 9 commits into from
Nov 12, 2018

Conversation

Blackbaud-AlexKingman
Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman commented Nov 8, 2018

Addresses #7

This update will also emit hidden column widths in the columnWidthChange output emitter. This will allow consumers to retain user width settings even after they show/hide columns.

src/app/public/modules/grid/grid.component.spec.ts Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Nov 10, 2018

Codecov Report

Merging #8 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   99.73%   99.73%   +<.01%     
==========================================
  Files           6        6              
  Lines         373      383      +10     
  Branches       54       55       +1     
==========================================
+ Hits          372      382      +10     
  Misses          1        1
Impacted Files Coverage Δ
src/app/public/modules/grid/grid.component.ts 99.63% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d89ef1...3ccd104. Read the comment docs.

@Blackbaud-SteveBrush Blackbaud-SteveBrush self-assigned this Nov 12, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 33d80b1 into master Nov 12, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the 7-resize-on-col-hide-fix branch November 12, 2018 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants