Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Performance update #13

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Performance update #13

merged 2 commits into from
Nov 8, 2018

Conversation

Blackbaud-AlexKingman
Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman commented Nov 5, 2018

Text highlight directive was being fired in every AfterContentChecked. This resulted in a spamming of the directive and caused some problems downstream - particularly with hyperlinks (see blackbaud/skyux2#2155).

@codecov-io
Copy link

codecov-io commented Nov 5, 2018

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files          28       28           
  Lines         496      496           
  Branches       77       78    +1     
=======================================
  Hits          495      495           
  Misses          1        1
Impacted Files Coverage Δ
...modules/text-highlight/text-highlight.directive.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4300f9f...4463af7. Read the comment docs.

Copy link
Member

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Blackbaud-AlexKingman Blackbaud-AlexKingman merged commit 7ec9163 into master Nov 8, 2018
@Blackbaud-AlexKingman Blackbaud-AlexKingman deleted the 2155-search-link-fix branch November 8, 2018 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants