This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fix chevron positioning #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 28 28
Lines 591 591
Branches 107 107
=====================================
Hits 591 591Continue to review full report at Codecov.
|
Blackbaud-SteveBrush
requested review from
blackbaud-conorwright,
Blackbaud-AlexKingman and
Blackbaud-TrevorBurch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The elements that make up the animated chevron are positioned related to their
hostelement (e.g.,sky-chevron). If the element's width changes, the chevron's positioning is affected and appears broken. To see this for yourself, simply add a red border to.sky-chevronand serve the SPA.This branch changes the positioning to absolute, so that the various pieces are always positioned correctly, even when the container's width changes.