Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

feat: add functions that will wrap observables w/ skywait #39

Merged
merged 2 commits into from
Jul 26, 2019

Conversation

Blackbaud-ColbyWhite
Copy link
Contributor

@Blackbaud-ColbyWhite Blackbaud-ColbyWhite commented Jul 23, 2019

it's common to want to wrap an observable in the wait service, particularly when making an http call. i.e. you want to show the blocking spinner while a backend call is happening. this makes that paradigm simple and avoids people having to duplicate that pattern throughout their code.

expected usage:

waitSvc.blockingWrap(http.get('url')).subscribe(doStuff);

credit to Nicklaus Glyder for the idea.

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @Blackbaud-ColbyWhite! One quick comment about backwards compatibility.

src/app/public/modules/wait/wait.service.ts Outdated Show resolved Hide resolved
@Blackbaud-SteveBrush
Copy link
Member

Docs issue: blackbaud/skyux2-docs#592

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 6b3ca17 into blackbaud:master Jul 26, 2019
@Blackbaud-ColbyWhite Blackbaud-ColbyWhite deleted the wrap branch July 26, 2019 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants