Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Added ability to have items on the right side of a toolbar #18

Merged
merged 10 commits into from
Apr 8, 2019

Conversation

Blackbaud-TrevorBurch
Copy link
Member

No description provided.

@Blackbaud-AlexKingman
Copy link
Contributor

Your component file name is toolbar-view-actions.compoennt.ts (notice "compoennt")

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          46     47    +1     
  Lines         488    491    +3     
  Branches       47     47           
=====================================
+ Hits          488    491    +3
Impacted Files Coverage Δ
src/app/public/modules/toolbar/toolbar.module.ts 100% <100%> (ø) ⬆️
.../modules/toolbar/toolbar-view-actions.component.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecfbc44...4bd0f37. Read the comment docs.

@Blackbaud-TrevorBurch
Copy link
Member Author

Fixed the file name

@Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-TrevorBurch Do we have a documentation issue for this feature?

@blackbaud-johnly
Copy link
Contributor

I created blackbaud/skyux2-docs#324 to document this. Thanks, @Blackbaud-SteveBrush.

Copy link
Contributor

@Blackbaud-ToddRoberts Blackbaud-ToddRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

styling seems like it's as good as it can be given the min height of the toolbar

Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch merged commit bef204d into master Apr 8, 2019
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the toolbar-view-actions branch October 16, 2019 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants